Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support the special version "MIN" #202

Open
wants to merge 24 commits into
base: master
Choose a base branch
from
Open

Support the special version "MIN" #202

wants to merge 24 commits into from

Conversation

omus
Copy link
Contributor

@omus omus commented Jan 5, 2024

Introduces a special version "MIN" which when passed in as the version allows the user to test against the earliest version of Julia compatible with their project. In order to determine this version the project file is read.

If we want we can choose another name for this special version but I would like to keep the name short as this usually appears in the CI check name which can already be quite long.

@omus
Copy link
Contributor Author

omus commented Jan 5, 2024

Did some basic local testing but need to add real tests before this is ready for review

@omus omus marked this pull request as ready for review January 9, 2024 01:20
@omus omus requested a review from a team as a code owner January 9, 2024 01:20
@DilumAluthge
Copy link
Member

Does this work for all julia = "..." compat entries, or just some? Can we document which ones it works for?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add tests for:

  1. Multiple entries separated by comma, e.g. ~1.7, ~1.8, ~1.9
  2. Hyphen ranges, e.g. 1.7 - 1.9

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And probably should also add tests for inequalities:

  1. < 1.9.0
  2. >= 1.6.0

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably also want to test the "multiple comma-separated entries" with a couple different permutations.

So e.g. we should test julia = "~1.7, ~1.8, ~1.9.

But we should also test julia = "~1.8, ~1.7, ~1.9 and make sure it gives the same result.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll add tests for all of these but based upon what I've seen in https://github.com/npm/node-semver#ranges all of these should work

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants