-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support the special version "MIN" #202
base: master
Are you sure you want to change the base?
Conversation
Did some basic local testing but need to add real tests before this is ready for review |
Does this work for all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add tests for:
- Multiple entries separated by comma, e.g.
~1.7, ~1.8, ~1.9
- Hyphen ranges, e.g.
1.7 - 1.9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And probably should also add tests for inequalities:
< 1.9.0
>= 1.6.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably also want to test the "multiple comma-separated entries" with a couple different permutations.
So e.g. we should test julia = "~1.7, ~1.8, ~1.9
.
But we should also test julia = "~1.8, ~1.7, ~1.9
and make sure it gives the same result.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll add tests for all of these but based upon what I've seen in https://github.com/npm/node-semver#ranges all of these should work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Introduces a special version "MIN" which when passed in as the
version
allows the user to test against the earliest version of Julia compatible with their project. In order to determine this version the project file is read.If we want we can choose another name for this special version but I would like to keep the name short as this usually appears in the CI check name which can already be quite long.