New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add onStop to useCountdown hook #484
base: master
Are you sure you want to change the base?
Conversation
Every time I used useCountdown I had to set a timeout for when the count is stopped, it would much easier if we have this inside the hook, it would be much cleaner.
|
please let me know if I have to add jsDoc to the hook in case of approval. |
Hi @samyarkd, |
refact: add stopCountdown function
added a unit test and modified the jsDocs 👍 also created a function to stop the countdown. |
@juliencrn congratulations on the V3, i noticed there has been a couple changes in the hook so modified the changes according to the V3 so there are no conflicts |
Every time I used useCountdown I had to set a timeout for when the count is stopped, it would much easier if we have this inside the hook, it would be much cleaner.