Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add a reset function to useLocalStorage #487

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lindesvard
Copy link

Added a reset function to useLocalStorage. I want to reset the state to the initial value. I know this is feasible without this change but thought it would be a nice addition.

Up to you guys if you want to merge it.

Copy link

changeset-bot bot commented Feb 16, 2024

⚠️ No Changeset found

Latest commit: 44bfb40

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@BlankParticle BlankParticle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The concept is ok, but we shouldn't expose a third variable in the function. You should keep the output array as it is, as it resembles useState.
You can make the reset function available on object destructuring.

Check useIntersectionObserver for example. If you don't understand something, feel free to ask.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants