Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support cross origin in useScript #598

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

ferrior
Copy link

@ferrior ferrior commented May 9, 2024

  1. Add optional attribute crossOrigin to UseScriptOptions with values 'anonymous' | 'use-credentials' | '' | null.
  2. Attach UseScriptOptions.crossOrigin to scriptNode.crossOrigin
  3. Update test cases and demos accordingly

Copy link

changeset-bot bot commented May 9, 2024

🦋 Changeset detected

Latest commit: f3c2011

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
usehooks-ts Major
www Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ferrior ferrior changed the title Support cross origin Support cross origin in useScript May 9, 2024
@ferrior
Copy link
Author

ferrior commented May 13, 2024

@juliencrn May I have your attention to review it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant