Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Java, plugins, and dependencies #727

Merged
merged 9 commits into from
Apr 14, 2023
Merged

Update Java, plugins, and dependencies #727

merged 9 commits into from
Apr 14, 2023

Conversation

nipafx
Copy link
Member

@nipafx nipafx commented Apr 13, 2023

Closes #729, closes #726.

Proposed commit message:

Update Gradle, Java, plugins, and dependencies (#729, #726 / #727)

* Gradle: 7.6 ~> 8.1
* Java:
	* regular build: 19 ~> 20 
	* experimental build: 20 ~> 21
	* include 20 in release build to make Javadoc 20 available
	  (and remove the need for multiple Java versions from all
	  other builds to make them simpler and faster)
* all plugins
	* updating Jacoco to 0.8.9 removed an error on JDK 20
* all dependencies
	* stick to same minor JUnit version because that's our policy
	* stick to same major Mockito version because the build failed
	  with 5.2.0

Closes: #729, #726
PR: #727

PR checklist

The following checklist shall help the PR's author, the reviewers and maintainers to ensure the quality of this project.
It is based on our contributors guidelines, especially the "writing code" section.
It shall help to check for completion of the listed points.
If a point does not apply to the given PR's changes, the corresponding entry can be simply marked as done.

Documentation (general)

  • There is documentation (Javadoc and site documentation; added or updated)
  • There is implementation information to describe why a non-obvious source code / solution got implemented
  • Site documentation has its own .adoc file in the docs folder, e.g. docs/report-entries.adoc
  • Site documentation in .adoc file references demo in src/demo/java instead of containing code blocks as text
  • Only one sentence per line (especially in .adoc files)
  • Javadoc uses formal style, while sites documentation may use informal style

Documentation (new extension)

  • The docs/docs-nav.yml navigation has an entry for the new extension
  • The package-info.java contains information about the new extension

Code

  • Code adheres to code style, naming conventions etc.
  • Successful tests cover all changes
  • There are checks which validate correct / false usage / configuration of a functionality and there are tests to verify those checks
  • Tests use AssertJ or our own PioneerAssert (which are based on AssertJ)

Contributing

  • A prepared commit message exists
  • The list of contributions inside README.md mentions the new contribution (real name optional)

@nipafx nipafx linked an issue Apr 13, 2023 that may be closed by this pull request
@nipafx nipafx added the full-build Triggers full build suite on PR label Apr 13, 2023
@nipafx nipafx requested a review from beatngu13 April 13, 2023 20:15
@nipafx nipafx mentioned this pull request Apr 13, 2023
@beatngu13 beatngu13 mentioned this pull request Apr 13, 2023
14 tasks
build.gradle.kts Outdated Show resolved Hide resolved
build.gradle.kts Outdated Show resolved Hide resolved
build.gradle.kts Outdated Show resolved Hide resolved
@nipafx
Copy link
Member Author

nipafx commented Apr 13, 2023

I think I'm all done. When everything's green, we can merge.

We can only really find out whether it works when we try a release, though. I'll try to make a meaningful change elsewhere, so a release makes sense.

@beatngu13 beatngu13 merged commit 1f07395 into main Apr 14, 2023
21 checks passed
@beatngu13 beatngu13 deleted the lab/java-21 branch April 14, 2023 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
full-build Triggers full build suite on PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to Gradle 8.1 Update Java, plugins, and dependencies
2 participants