FreePort resource to create ServerSocket #733
Conversation
…into issue/141-free-port-extension
|
A couple things that need to be updated still:
|
…into issue/141-free-port-resource
…into issue/141-free-port-resource
…into issue/141-free-port-resource
docs/free-port.adoc
Outdated
| to test a failure scenario when there is no service at given port. | ||
|
|
||
| It's a JUnit Jupiter extension which provides a free port for above-mentioned use cases. | ||
| Also, there is no guarantee that the port will still be available by the time you use it. |
There was a problem hiding this comment.
Maybe highlight this (port might be not free when used) as a note / warning?
| import java.lang.annotation.RetentionPolicy; | ||
| import java.lang.annotation.Target; | ||
|
|
||
| @New(FreePort.class) |
There was a problem hiding this comment.
I think it means that a new instance of the FreePort class is created, but I would like to double check as I know @New only as a deprecated CDI annotation (and I'm not getting any other proper search result from google 🆘). This would mean that the user always get a Socket on port zero - which is hardly what they want I guess.
There was a problem hiding this comment.
Again - NewPort was removed. The @New annotation is part of our resources abstract extension.
…into issue/141-free-port-resource
|
I intend to tackle #808 in this one when I have the time, actually. |
|
Looks good to me, @beatngu13 would you also take a look? @Michael1993 It's still a draft? :D |
Another approach to #141. Based on #541