fix(react): remove attribute when is "false" #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igorwessel
requested review from
felipefialho,
a team and
LucasGomestl
and removed request for
a team
|
|
Some links about this problem: https://custom-elements-everywhere.com/#react |
igorwessel
changed the title
igorwessel
requested review from
schirrel,
tassioFront,
a team and
mauriciomutte
schirrel
reviewed
Jul 20, 2023
igorwessel
force-pushed
the
fix/disabled-in-button-host
branch
3 times, most recently
from
7c8424c
to
32dc49d
Compare
igorwessel
force-pushed
the
fix/disabled-in-button-host
branch
from
32dc49d
to
3e48fe8
Compare
igorwessel
requested review from
tassioFront,
mauriciomutte,
schirrel and
felipefialho
tassioFront
approved these changes
Jul 21, 2023
felipefialho
approved these changes
Jul 21, 2023
schirrel
approved these changes
Jul 24, 2023
BernardoSemiOficial
approved these changes
Jul 24, 2023
|
🚀 |
mauriciomutte
approved these changes
Jul 24, 2023
|
[juntossomosmais_atomium_core] Kudos, SonarCloud Quality Gate passed! |
This was referenced Jul 25, 2023
Merged
Closed
Merged
Merged
felipefialho
pushed a commit
that referenced
this pull request
Aug 3, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Infos
Task
What is being delivered?
We are adding a fix after finishing transpiling the components to React.
What impacts?
Reversal plan
Reset commit to the previous version 7809bb3
Evidences
Storybook - React
Gravacao.de.Tela.2023-07-18.as.17.45.05.mov
Build
Gravacao.de.Tela.2023-07-19.as.17.44.20.mov
Build in watch mode
Gravacao.de.Tela.2023-07-19.as.17.46.48.mov