Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add disk monitoring #233

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Conversation

iandesj
Copy link

@iandesj iandesj commented Apr 26, 2024

This is continuation of what #232 is trying to enhance!

Additionally, this PR:

  • Fixes computing the disk warning state
  • Propagates all resources in warning, not just memory
  • Tweaks the react condition to look at all warnings

Copy link

welcome bot commented Apr 26, 2024

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@iandesj
Copy link
Author

iandesj commented Apr 26, 2024

@krassowski Would you be able to add the correct label(s)?

@iandesj
Copy link
Author

iandesj commented Apr 30, 2024

@krassowski (and other contrib's) what would help get this across the line?

@iandesj
Copy link
Author

iandesj commented Jun 3, 2024

My project has been using these changes in production for nearly a month now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants