adding exception handling for room start tasks #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jzhang20133
force-pushed
the
yroom-exception
branch
2 times, most recently
from
19c131b
to
87eaafa
Compare
Zsailer
reviewed
Apr 26, 2024
jzhang20133
force-pushed
the
yroom-exception
branch
from
87eaafa
to
9f1a4b4
Compare
jzhang20133
force-pushed
the
yroom-exception
branch
7 times, most recently
from
2cc7276
to
4deeaf5
Compare
Zsailer
reviewed
Apr 26, 2024
jzhang20133
force-pushed
the
yroom-exception
branch
from
4deeaf5
to
1f2a11c
Compare
Zsailer
approved these changes
Apr 26, 2024
|
Nice work @jzhang20133! Looks good to me! Let's merge and iterate from here. |
|
Congrats on your first merged pull request in this project! 🎉 |
|
Thanks @jzhang20133. |
Comment on lines
+154
to
+158
| try: | ||
| self._task_group.start_soon(self.ystore.write, update) | ||
| self.log.debug("Writing Y update to YStore") | ||
| except Exception as exception: | ||
| self._handle_exception(exception) |
There was a problem hiding this comment.
I think that a follow-up to this PR would be to not handle exceptions here, but have a YStore have an optional exception handler, and do the handling there.
There was a problem hiding this comment.
Good point, @davidbrochart. I've created the following issue to track: #36
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes, we have observed issues that task group in websocket_server is no longer active and user will be stuck after that and no longer able to access files and have to restart nb servers to unblock. _task_group instance variable in websocket_server will become inactive when one of its tasks of starting room or its children task group task fail with exception.
One place where an exception can occur is in the _broadcast_update method, which is a key task in children task group of _task_group in websocket_server. In this PR, the exception is handled and logged to prevent the parent task from crashing while still displaying the issue that will allow us better handle them in the future.
Resolving open source issues:
jupyterlab/jupyter-collaboration#290
jupyterlab/jupyter-collaboration#245