Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downloading html file from file explorer opens file in new tab instead of downloading #2606

Closed
kevmk04 opened this issue Jun 10, 2019 · 7 comments

Comments

@kevmk04
Copy link

kevmk04 commented Jun 10, 2019

I have an .html file that was generated by the plotly offline.iplot function. My typical workflow is to create the file from a notebook and download the html file to share with colleagues. On an existing jupyterhub/jupyterlab install this functionality works fine. It downloads directly to my local download folder.

I recently setup a TLJH install on a new server. When I try to download the same .html file (or any html file for that matter), it opens the file in a new browser tab instead of downloading it. It also seems to try to do this with other file extensions and then downloads them normally, but it does flash open a new tab briefly before downloading. The older install does not exhibit that same flash of a new tab for other files types.

I'm using Chrome as the browser.

Old jupyterhub/jupyterlab setup where download works:
jupyterhub version: 0.8.1
jupyterlab version: 0.35.4
notebook version: 5.4.1
Installed manually

New jupyterhub/jupyterlab setup where download does not work:
jupyterhub version: 1.0
jupyterlab version: 0.35.4
notebook version: 5.7.8
Installed with TLJH installer

I'm unsure if this is a jupyterlab issue, something with TLJH install, or something else entirely.

@kevmk04 kevmk04 closed this as completed Jun 10, 2019
@wqh17101
Copy link

wqh17101 commented Aug 9, 2019

why you close this? @kevmk04
how to fix it?

@kevmk04
Copy link
Author

kevmk04 commented Aug 10, 2019

@wqh17101 I closed the issue because the problem is actually a jupyterlab problem not a hub problem. I have an open issue in the jupyterlab GitHub for this problem.

@wqh17101
Copy link

@kevmk04 all right

@kevmk04
Copy link
Author

kevmk04 commented Aug 12, 2019

@wqh17101 Release 1.0.5 of JupyterLab resolves this issue.

@wqh17101
Copy link

well , let`s see it @kevmk04

@wqh17101
Copy link

@kevmk04 all right , it works. Do you know what changes had been done to fix it?

@kevmk04
Copy link
Author

kevmk04 commented Aug 13, 2019

@wqh17101 Look at pull 6686 in the JupyterLab repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants