Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add script to auto bump version in top level #122

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mahendrapaipuri
Copy link
Collaborator

  • The script ensures that version in top level package.json would be consistent with packages

  • Run this script after bump version step in jupyter-releaser

@jtpio Do you think a simple script like this would be enough for stream lining releases?

* The script ensures that version in top level package.json would be consistent with packages

* Run this script before bump version in jupyter-releaser

Signed-off-by: Mahendra Paipuri <mahendra.paipuri@gmail.com>
@jtpio jtpio linked an issue Apr 8, 2024 that may be closed by this pull request
@jtpio
Copy link
Member

jtpio commented Apr 8, 2024

Thanks @mahendrapaipuri for looking into this.

Yes it should be fine for now if we always bump all the packages together during a release. Maybe we can later investigate how the packages could be versioned independently.

@mahendrapaipuri
Copy link
Collaborator Author

What do you think about following workflow for independent versionining:

  • We skip bump-version step of jupyter-releaser
  • We bump versions of few or all packages manually with a separate PR. Versions can be different for different packages
  • The current custom script will bump the version of top level package.json automatically. The tag will be created in the repo based on this version and so we should choose a versioning strategy that is meaningful.
  • In the prep-release workflow, we create an additional input like packages and we will pass the packages that have been bumped from this input. We pass this information to jupyter-releaser using env var RH_PYTHON_PACKAGES.

This will still build npm artifacts for all packages and attempt to publish them. I am not sure if npm registry throws an error if we are attempting to publish the same version of the package or ignores it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix handling of the top-level version
2 participants