Skip to content
This repository has been archived by the owner on Jan 26, 2022. It is now read-only.

Add tests for stackTrace, scopes, variables #13

Merged
merged 8 commits into from Aug 30, 2019

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Aug 16, 2019

Add several tests for stackTrace, scopes and variablesReference.

They can also serve as a reference for the protocol messages.

@jtpio jtpio force-pushed the test-protocol branch 2 times, most recently from 16d13ec to e1eb8c6 Compare August 20, 2019 09:44
@jtpio
Copy link
Member Author

jtpio commented Aug 20, 2019

This change also adds an execute method to the DebugSession, used to send a request_execute message to the kernel and start debugging the code.

@jtpio jtpio changed the title [WIP] Add tests for stackTrace, scopes, variables Add tests for stackTrace, scopes, variables Aug 20, 2019
@jtpio
Copy link
Member Author

jtpio commented Aug 20, 2019

This could be also rebased on #15 if we get it in first.

src/session.ts Outdated Show resolved Hide resolved
src/session.ts Outdated Show resolved Hide resolved
@afshin
Copy link
Member

afshin commented Aug 22, 2019

Hm, the tests hang for me:

Screen Shot 2019-08-22 at 11 54 19 AM

@jtpio
Copy link
Member Author

jtpio commented Aug 22, 2019

Looks like it cannot find xeus-python and start it.

@jtpio
Copy link
Member Author

jtpio commented Aug 22, 2019

Maybe we should make the tests install the spec for xpython to the temp data_dir instead: https://github.com/jupyterlab/jupyterlab/blob/f1bc02ced61881df94c49929837c49c022f5b115/jupyterlab/tests/test_jupyterlab.py#L126

@afshin
Copy link
Member

afshin commented Aug 22, 2019

That sounds like a good idea. Hm, I have the kernel when I run lab ...

@jtpio
Copy link
Member Author

jtpio commented Aug 26, 2019

The last commit installs the kernel spec for xeus-python automatically when running the tests.

Opened jupyterlab/jupyterlab#7089 to make it easier to do the same in other third-party extensions.

@jtpio
Copy link
Member Author

jtpio commented Aug 29, 2019

@afshin @KsavinN what do you think about getting this one in?

Then we can take care of #32 and start integrating the debug messages with the UI.

Copy link
Member

@afshin afshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@afshin afshin merged commit 6d08bed into jupyterlab:master Aug 30, 2019
@jtpio jtpio deleted the test-protocol branch August 30, 2019 15:23
jtpio pushed a commit that referenced this pull request Oct 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants