This repository has been archived by the owner on Jan 26, 2022. It is now read-only.
Add keywords to package.json #343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh man, the new libraries are making tests flaky. It seems likely that either we or the libraries have a race condition. |
|
Yes, I thought this was fixed by #337 (comment). We should check one more time whether the kernels are properly awaited. The problem is that these issues are difficult to reproduce locally (tests usually always pass). |
|
We've seen those failures in the past from time to time, but they seem to be more frequent after the switch to 2.0. |
jtpio
force-pushed
the
package-keywords
branch
from
406bbfd
to
7b1c8be
Compare
jtpio
force-pushed
the
package-keywords
branch
from
7b1c8be
to
ed8b5b9
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make the extension discoverable via the extension manager.