Upgrade to jupyterlab 4 #1236

HaudinFlorence · 2023-04-20T08:30:29Z

Update jupyterlab-git for jupyterlab 4

welcome · 2023-04-20T08:30:31Z

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.

You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

github-actions · 2023-04-20T08:30:45Z

👈 Launch a binder notebook on branch HaudinFlorence/jupyterlab-git/upgrade_jupyterlab_git

mahendrapaipuri · 2023-06-17T18:07:07Z

What is the status of this PR? Is there any timeline when it will be finished?

HaudinFlorence · 2023-06-19T07:55:48Z

What is the status of this PR? Is there any timeline when it will be finished?

Thanks @mahendrapaipuri for your interest. It is still a work in progress.

krassowski · 2023-06-20T16:51:11Z

@HaudinFlorence it looks like this one accumulated a number of merge conflicts. I or one of my colleagues would be happy to push this forward by resolving the conflicts and fixing up any outstanding issues. Did you plan to work on this PR anytime soon, or should we go ahead and open a new PR (or a PR against your branch - whichever preferred)?

HaudinFlorence · 2023-06-21T13:57:36Z

@HaudinFlorence it looks like this one accumulated a number of merge conflicts. I or one of my colleagues would be happy to push this forward by resolving the conflicts and fixing up any outstanding issues. Did you plan to work on this PR anytime soon, or should we go ahead and open a new PR (or a PR against your branch - whichever preferred)?

@krassowski Thanks for proposing some help. We are planning to rework on this PR in the future. But the migration process has shown that the update of jupyterLab-git to jupyterLab4 requires the migration of nbdime to CodeMirror6. So we have been working on it in the past few weeks and are still currently on it. We will then go back to this PR. In the meantime, if you want to rebase it, please feel free to do it. Thanks in advance for your help.
cc @fcollonval @JohanMabille

krassowski · 2023-06-21T14:36:26Z

Sounds like a plan! If you get stuck with some issue on CodeMirror6 transition feel welcome to ping me, I am now working on LSP which has a large surface of contact with CodeMirror6.

dlqqq · 2023-07-27T23:30:56Z

@HaudinFlorence Hello Florence! I recently upgraded both Jupyter Scheduler and Jupyter AI to JupyterLab 4, and I'd be happy to help with this migration. Our team at AWS has a vested interest in getting jupyterlab-git JL4-compatible before the end of the year, ideally within the next month or two, so we are happy to be of assistance.

Would you be open to meeting virtually sometime to see how I can help? I also fully understand if you're already 99% finished and would like to complete it alone, just let me know. My email is on my GitHub profile.

HaudinFlorence · 2023-07-31T16:13:03Z

@dlqqq Thanks for your message and for proposing some help. We are still in the process of migrating nbdime to codemirror6 and are close to have a working version with most of the current features jupyter/nbdime#664. Then we will go back to this PR.

psychemedia · 2023-08-07T19:32:19Z

just a comment on timelines; I'm in the edu sector and like many other educators we're on a sprint over summer updating things for September (the academic year start); not having jupyterlab-git is a blocker for many educators who want to migrate to JupyterLab v4 and expect students to use git in support of coursework (things tend to get locked in for the forthcoming academic year over the summer).

HaudinFlorence · 2023-08-09T08:52:47Z

@psychemedia Thanks for your message. We are still on nbdime update and then (the sooner we can) we will move back to finalizing the update of jupyterlab-git.

JasonWeill · 2023-08-23T22:58:19Z

@HaudinFlorence Thanks for your work on the related nbdime PR! Is there anything we can do to help that PR or this PR move forward? Do you have an estimate for when you would expect this PR to be ready for submission?

HaudinFlorence · 2023-08-25T08:10:53Z

@HaudinFlorence Thanks for your work on the related nbdime PR! Is there anything we can do to help that PR or this PR move forward? Do you have an estimate for when you would expect this PR to be ready for submission?

@JasonWeill Thanks for your message and proposition for help. The PR on updating nbdime to jupyterlab4 and so to CM6 is almost ready for review (it will be tagged to request review today hopefully). Feel free to have a look at it: jupyter/nbdime#664
Then it will depend on the time required for the review of nbdime PR and for having a new version to be used with jupyterlab-git. It is thus a bit difficult to give a precise timeline. But things are progressing and should be rather quick once a new version of nbdime is ready.

HaudinFlorence · 2023-08-25T21:44:27Z

The PR updating nbdime to jupyterlab4 is ready for review here: jupyter/nbdime#664. Reviews, testing and comments are welcome. Thanks.

vkaidalov · 2023-09-13T11:33:30Z

Hi @HaudinFlorence!
Given that jupyter/nbdime#673 is almost finished, would you be so kind to tell how much time will be needed to finish this MR? At least a very rough estimation, e.g. somewhere in the end of this month? Thanks

HaudinFlorence · 2023-09-13T12:54:59Z

Hi @HaudinFlorence! Given that jupyter/nbdime#673 is almost finished, would you be so kind to tell how much time will be needed to finish this MR? At least a very rough estimation, e.g. somewhere in the end of this month? Thanks

Hi @vkaidalov,
Thanks for your message. The estimated time to finish this PR is mid October but there are still blockers making any target date very provisional.

JasonWeill · 2023-09-13T15:17:28Z

@HaudinFlorence Thank you very much for your hard work on the nbdime PR! What other blockers affect this PR?

HaudinFlorence · 2023-09-13T15:43:14Z

@HaudinFlorence Thank you very much for your hard work on the nbdime PR! What other blockers affect this PR?

Hi @JasonWeill,
Thanks for your message. The blocker that is the most difficult to evaluate is related to the improvement of nbdime API for diff and merge views in such a way that it can be reused in jupyterlab-git for plain text files as CM6 does not have merge addon replacement.

krassowski · 2023-09-13T15:53:57Z

Can you elaborate on what is missing in https://github.com/codemirror/merge? Maybe we could contribute to it to enable reuse in jupyterlb-git? Are there upstream issues open that we could help with? For the record there are different ways of contributing and the author was raising funds some time ago: https://discuss.codemirror.net/t/merge-view-implementation/5072

Khagesh16 · 2023-09-14T17:47:04Z

Please, provide jlab 4 support

HaudinFlorence · 2023-09-14T21:11:42Z

Can you elaborate on what is missing in https://github.com/codemirror/merge? Maybe we could contribute to it to enable reuse in jupyterlb-git? Are there upstream issues open that we could help with? For the record there are different ways of contributing and the author was raising funds some time ago: https://discuss.codemirror.net/t/merge-view-implementation/5072

Hi @krassowski. Thanks for your comments. To be honnest, I don't know how to answer these points and how much effort it would be to make a 3 way-merge view in CM6 if it is the point raised here.

fcollonval · 2023-09-18T12:05:24Z

For all people willing to push this forward, there are two meta issues on nbdime listing actions needed to help with this:

[required actions] [Meta issue] Integration in @jupyterlab/git jupyter/nbdime#680
[other points] Migration to jupyterlab 4.0 jupyter/nbdime#659

Please assign yourself to an issue when you start working on it so that we can split efficiently the effort between those issues.

RafaelClovr · 2023-10-04T10:41:25Z

Hi, one question, if pyhton 3.7 is deprecated, should be removed from CI?

benz0li · 2023-10-24T07:56:27Z

@fcollonval Is there an approximate timeframe for the release that will support JupyterLab 4?

welcome · 2023-10-24T13:27:37Z

Congrats on your first merged pull request in this project! 🎉

Thank you for contributing, we are very proud of you! ❤️

krassowski · 2023-10-25T09:19:10Z

@benz0li it will likely happen once final nbdime version is released. In the meantime you can help by testing the latest prerelease (currently v0.50.0a0) and report any issues you see.

benz0li · 2023-10-25T09:25:17Z

@benz0li it will likely happen once final nbdime version is released.

@krassowski Thanks for the info. This is perfectly fine.

In the meantime you can help by testing the latest prerelease (currently v0.50.0a0) and report any issues you see.

I did very basic smoke testing and it worked OK.

Unrelated to this issue but worth mentioning: There is also jupyterlab/jupyterlab_pygments#31: Progress seems to have stalled.

HaudinFlorence force-pushed the upgrade_jupyterlab_git branch from a0badcb to 1e878f4 Compare April 20, 2023 13:29

mfakaehler mentioned this pull request Jun 19, 2023

Hotfix/dependency update #1249

Merged

krassowski mentioned this pull request Jul 5, 2023

Extension Compatibility with JupyterLab 4.0 jupyterlab/jupyterlab#14590

Open

fcollonval mentioned this pull request Aug 15, 2023

Extensions compatibility for notebook 7 jupyter/notebook#7012

Open

psychemedia mentioned this pull request Aug 23, 2023

Support for JupyterLab 4.0 #1245

Closed

fcollonval added the maintenance label Sep 19, 2023

fcollonval force-pushed the upgrade_jupyterlab_git branch from 1e878f4 to ed39565 Compare September 19, 2023 15:02

fcollonval added 12 commits October 23, 2023 15:35

Fix accessing the default browser

dfd1de3

Self review following application of the template

3d96fc2

First working version for diff text file

cf67007

Update yarn.locks following rebase

542af57

Use setting to add clone button in file browser

b5ebb67

Remove the logger in favor of the notifications

db8b4f1

Improve text diff for merge

0636ea2

Fix lots of styling issues

b1c0afc

Fix notebook widget API

6241ad2

Set notification autoClose to get similar behavior

49650ac

Improve styling

8e3c493

Drop test against 3.7

638ecb1

fcollonval force-pushed the upgrade_jupyterlab_git branch from 4b80f30 to a1f34a2 Compare October 23, 2023 14:21

Fix tests

2ddbf65

fcollonval force-pushed the upgrade_jupyterlab_git branch from a1f34a2 to 2ddbf65 Compare October 23, 2023 14:29

fcollonval added 3 commits October 23, 2023 16:30

Update checkout action

97ba7f1

Upload extension only for python 3.10

4577c58

Fix integration test utils

c383552

Fix integration tests

cd8f265

fcollonval force-pushed the upgrade_jupyterlab_git branch from d4136f7 to cd8f265 Compare October 24, 2023 12:23

Update snapshots

a695040

fcollonval merged commit e77defa into jupyterlab:main Oct 24, 2023
8 checks passed

natsukium mentioned this pull request Oct 27, 2023

python311Packages.jupyterlab-git: 0.42.0 -> 0.50.0rc0 NixOS/nixpkgs#262742

Merged

13 tasks

This was referenced Nov 28, 2023

Look into potential new JLab 4 extensions to add nebari-dev/nebari#2135

Open

Test existing extensions with JLab 4 nebari-dev/nebari#2134

Closed

Zsailer mentioned this pull request May 14, 2024

Unable to set email/username on a remote server #1324

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade to jupyterlab 4 #1236

Upgrade to jupyterlab 4 #1236

HaudinFlorence commented Apr 20, 2023 •

edited by fcollonval

welcome bot commented Apr 20, 2023

github-actions bot commented Apr 20, 2023

mahendrapaipuri commented Jun 17, 2023

HaudinFlorence commented Jun 19, 2023

krassowski commented Jun 20, 2023

HaudinFlorence commented Jun 21, 2023 •

edited

krassowski commented Jun 21, 2023

dlqqq commented Jul 27, 2023

HaudinFlorence commented Jul 31, 2023

psychemedia commented Aug 7, 2023 •

edited

HaudinFlorence commented Aug 9, 2023 •

edited

JasonWeill commented Aug 23, 2023

HaudinFlorence commented Aug 25, 2023 •

edited

HaudinFlorence commented Aug 25, 2023 •

edited

vkaidalov commented Sep 13, 2023

HaudinFlorence commented Sep 13, 2023 •

edited

JasonWeill commented Sep 13, 2023

HaudinFlorence commented Sep 13, 2023 •

edited

krassowski commented Sep 13, 2023

Khagesh16 commented Sep 14, 2023

HaudinFlorence commented Sep 14, 2023 •

edited

fcollonval commented Sep 18, 2023

RafaelClovr commented Oct 4, 2023

benz0li commented Oct 24, 2023

welcome bot commented Oct 24, 2023

krassowski commented Oct 25, 2023

benz0li commented Oct 25, 2023 •

edited

Upgrade to jupyterlab 4 #1236

Upgrade to jupyterlab 4 #1236

Conversation

HaudinFlorence commented Apr 20, 2023 • edited by fcollonval

welcome bot commented Apr 20, 2023

github-actions bot commented Apr 20, 2023

mahendrapaipuri commented Jun 17, 2023

HaudinFlorence commented Jun 19, 2023

krassowski commented Jun 20, 2023

HaudinFlorence commented Jun 21, 2023 • edited

krassowski commented Jun 21, 2023

dlqqq commented Jul 27, 2023

HaudinFlorence commented Jul 31, 2023

psychemedia commented Aug 7, 2023 • edited

HaudinFlorence commented Aug 9, 2023 • edited

JasonWeill commented Aug 23, 2023

HaudinFlorence commented Aug 25, 2023 • edited

HaudinFlorence commented Aug 25, 2023 • edited

vkaidalov commented Sep 13, 2023

HaudinFlorence commented Sep 13, 2023 • edited

JasonWeill commented Sep 13, 2023

HaudinFlorence commented Sep 13, 2023 • edited

krassowski commented Sep 13, 2023

Khagesh16 commented Sep 14, 2023

HaudinFlorence commented Sep 14, 2023 • edited

fcollonval commented Sep 18, 2023

RafaelClovr commented Oct 4, 2023

benz0li commented Oct 24, 2023

welcome bot commented Oct 24, 2023

krassowski commented Oct 25, 2023

benz0li commented Oct 25, 2023 • edited

HaudinFlorence commented Apr 20, 2023 •

edited by fcollonval

HaudinFlorence commented Jun 21, 2023 •

edited

psychemedia commented Aug 7, 2023 •

edited

HaudinFlorence commented Aug 9, 2023 •

edited

HaudinFlorence commented Aug 25, 2023 •

edited

HaudinFlorence commented Aug 25, 2023 •

edited

HaudinFlorence commented Sep 13, 2023 •

edited

HaudinFlorence commented Sep 13, 2023 •

edited

HaudinFlorence commented Sep 14, 2023 •

edited

benz0li commented Oct 25, 2023 •

edited