Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update yarn lock for proper checksum #1326

Merged
merged 4 commits into from
May 15, 2024
Merged

Conversation

Zsailer
Copy link
Member

@Zsailer Zsailer commented May 14, 2024

Noticed that the tests have been failing for awhile.

I did a few things here to clean them up and get everything green (once someone adds a label 馃槃).

  • It looks like a checksum difference in the yarn.lock. Updated here.
  • Fix broken link
  • Run black again to catch updates that were conflicting in pre-commit.

Copy link

welcome bot commented May 14, 2024

Thanks for submitting your first pull request! You are awesome! 馃

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 馃憢

Welcome to the Jupyter community! 馃帀

Copy link

Binder 馃憟 Launch a Binder on branch Zsailer/jupyterlab-git/yarn-lock

Copy link
Member

@krassowski krassowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you! Let's fix the integration tests in a follow-up PR.

@krassowski krassowski merged commit d4b0f63 into jupyterlab:main May 15, 2024
7 of 10 checks passed
Copy link

welcome bot commented May 15, 2024

Congrats on your first merged pull request in this project! 馃帀
congrats
Thank you for contributing, we are very proud of you! 鉂わ笍

@Zsailer
Copy link
Member Author

Zsailer commented May 15, 2024

Thank you, @krassowski!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants