enabled full typescript sourcemaps (with breakpoints and everything!) #447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this will make debugging both jlab core and extensions much easier inthe future
fcollonval
approved these changes
Nov 7, 2019
|
You can actually see this in action now if you install Jupyterlab from the latest HEAD (with jupyterlab/jupyterlab#7541) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not a user-facing change, but rather a bump in quality of life for the devs. To see the full benefit, this will also require some tweaks to the webpack build system in core (I think I have that already figured out, though).
The upshot is that when you debug the code (eg, using Chrome devtools), instead of the compiled Javascript, you'll see the original
.tssources. You can also set breakpoints wherever you like in the sources, and they'll work correctly/consistently