Skip to content

Commit

Permalink
Delete TODO notes about restarts timing out.
Browse files Browse the repository at this point in the history
jupyter/notebook#3705 noted some issues with kernel messages. I think these were mainly because we disconnected and reconnected the websocket on restart. We no longer do this, and these tests seem to pass, so let’s remove the TODO and keep an eye on it.
  • Loading branch information
jasongrout committed May 15, 2019
1 parent 2884cf5 commit 0743bb2
Showing 1 changed file with 0 additions and 6 deletions.
6 changes: 0 additions & 6 deletions tests/test-services/src/kernel/ikernel.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -303,8 +303,6 @@ describe('Kernel.IKernel', () => {
await emission;
});

// TODO: seems to be sporadically timing out if we await the restart. See
// https://github.com/jupyter/notebook/issues/3705.
it('should get a restarting status', async () => {
const emission = testEmission(defaultKernel.statusChanged, {
find: () => defaultKernel.status === 'restarting'
Expand Down Expand Up @@ -612,8 +610,6 @@ describe('Kernel.IKernel', () => {
});

describe('#restart()', () => {
// TODO: seems to be sporadically timing out if we await the restart. See
// https://github.com/jupyter/notebook/issues/3705.
it('should restart and resolve with a valid server response', async () => {
await defaultKernel.restart();
await defaultKernel.ready;
Expand Down Expand Up @@ -646,8 +642,6 @@ describe('Kernel.IKernel', () => {
await expectFailure(restart);
});

// TODO: seems to be sporadically timing out if we await the restart. See
// https://github.com/jupyter/notebook/issues/3705.
it('should dispose of existing comm and future objects', async () => {
const kernel = defaultKernel;
const comm = kernel.connectToComm('test');
Expand Down

0 comments on commit 0743bb2

Please sign in to comment.