Add a sourceChanged signal and use it to notify of command changes.

jupyterlab · Oct 17, 2019 · 177f20f · 177f20f
1 parent 2afb2ae
commit 177f20f
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 4 deletions.
diff --git a/packages/logconsole-extension/package.json b/packages/logconsole-extension/package.json
@@ -41,6 +41,7 @@
     "@jupyterlab/notebook": "^2.0.0-alpha.1",
     "@jupyterlab/rendermime": "^2.0.0-alpha.1",
     "@jupyterlab/statusbar": "^2.0.0-alpha.1",
+    "@phosphor/messaging": "^1.3.0",
     "@phosphor/signaling": "^1.3.0",
     "@phosphor/widgets": "^1.9.0",
     "react": "~16.8.4"

diff --git a/packages/logconsole-extension/src/index.tsx b/packages/logconsole-extension/src/index.tsx
@@ -488,8 +488,13 @@ function activateLogConsole(
       return true;
     });
 
+    logConsolePanel.sourceChanged.connect(() => {
+      app.commands.notifyCommandChanged();
+    });
+
     logConsoleWidget.disposed.connect(() => {
       logConsoleWidget = null;
+      app.commands.notifyCommandChanged();
       status.model.flashEnabled = flashEnabled;
     });
 
@@ -499,6 +504,7 @@ function activateLogConsole(
     });
 
     logConsoleWidget.update();
+    app.commands.notifyCommandChanged();
   };
 
   app.commands.addCommand(CommandIDs.open, {
@@ -516,8 +522,6 @@ function activateLogConsole(
     }
   });
 
-  // TODO: call app.commands.notifyCommandChanged() when enabled status
-  // changes
   app.commands.addCommand(CommandIDs.addTimestamp, {
     label: 'Add Timestamp',
     execute: () => {

diff --git a/packages/logconsole/src/widget.ts b/packages/logconsole/src/widget.ts
@@ -451,13 +451,21 @@ export class LogConsolePanel extends StackedPanel {
   /**
    * The log source displayed
    */
-  get source(): string {
+  get source(): string | null {
     return this._source;
   }
-  set source(name: string) {
+  set source(name: string | null) {
     this._source = name;
     this._showOutputFromSource(this._source);
     this._handlePlaceholder();
+    this._sourceChanged.emit(name);
+  }
+
+  /**
+   * Signal for source changes
+   */
+  get sourceChanged(): ISignal<this, string | null> {
+    return this._sourceChanged;
   }
 
   private _handlePlaceholder() {
@@ -554,6 +562,7 @@ export class LogConsolePanel extends StackedPanel {
   private _loggerRegistry: ILoggerRegistry;
   private _outputAreas = new Map<string, LogConsoleOutputArea>();
   private _source: string | null = null;
+  private _sourceChanged = new Signal<this, string | null>(this);
   private _entryLimit: number = DEFAULT_LOG_ENTRY_LIMIT;
   private _scrollTimer: number = null;
   private _placeholder: Widget;