Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Document the separator generation better.
- Loading branch information
1 parent
b2229c0
commit 2a3827f
Showing
1 changed file
with
6 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2a3827f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Setting MAX_DIRECTORIES to 2 is not enough breadcrumbs for me. Why is this not a configurable parameter? How much other code in crumbs.ts breaks when this value is changed. Seems like there's a lot of hard-wired logic that assumes this number is only ever 2. Would anybody be open to a PR that makes this configurable?