Merge pull request #7672 from blink1073/fix-input-area-display

Fix handling of code editor refresh
jupyterlab · Dec 23, 2019 · 3c6521e · 3c6521e
2 parents 72d9e17 + 6120442
commit 3c6521e
Showing 1 changed file with 9 additions and 2 deletions.
diff --git a/packages/codeeditor/src/widget.ts b/packages/codeeditor/src/widget.ts
@@ -121,6 +121,9 @@ export class CodeEditorWrapper extends Widget {
     node.addEventListener('p-dragleave', this);
     node.addEventListener('p-dragover', this);
     node.addEventListener('p-drop', this);
+    // We have to refresh at least once after attaching,
+    // while visible.
+    this._hasRefreshedSinceAttach = false;
     if (this.isVisible) {
       this.update();
     }
@@ -141,7 +144,7 @@ export class CodeEditorWrapper extends Widget {
    * A message handler invoked on an `'after-show'` message.
    */
   protected onAfterShow(msg: Message): void {
-    if (this._updateOnShow) {
+    if (this._updateOnShow || !this._hasRefreshedSinceAttach) {
       this.update();
     }
   }
@@ -161,7 +164,10 @@ export class CodeEditorWrapper extends Widget {
    * A message handler invoked on an `'update-request'` message.
    */
   protected onUpdateRequest(msg: Message): void {
-    this.editor.refresh();
+    if (this.isVisible) {
+      this._hasRefreshedSinceAttach = true;
+      this.editor.refresh();
+    }
   }
 
   /**
@@ -278,6 +284,7 @@ export class CodeEditorWrapper extends Widget {
   }
 
   private _updateOnShow: boolean;
+  private _hasRefreshedSinceAttach = false;
 }
 
 /**