Only display node structure in JSONTree for arrays and empty objects

jupyterlab · Sep 18, 2019 · 47e11f9 · 47e11f9
1 parent 8013d19
commit 47e11f9
Showing 1 changed file with 9 additions and 6 deletions.
diff --git a/packages/json-extension/src/component.tsx b/packages/json-extension/src/component.tsx
@@ -71,13 +71,16 @@ export class Component extends React.Component<IProps, IState> {
           }}
           invertTheme={false}
           keyPath={[root]}
-          getItemString={(type, data, itemType) =>
-            ((Array.isArray(data) && data) || Object.keys(data)).length ===
-            0 ? (
-              // When there is no data, we display the collection type ("{}" or "[]").
+          getItemString={(type, data, itemType, itemString) =>
+            Array.isArray(data) ? (
+              // Always display array type and the number of items i.e. "[] 2 items".
+              <span>
+                {itemType} {itemString}
+              </span>
+            ) : Object.keys(data).length === 0 ? (
+              // Only display object type when it's empty i.e. "{}".
               <span>{itemType}</span>
-            ) : // Otherwise, the data speaks for itself.
-            null
+            ) : null
           }
           labelRenderer={([label, type]) => {
             // let className = 'cm-variable';