Merge pull request #7824 from ggbhat/htmlviewer-refresh-issue

Fixed refresh issue for html viewer(slides)-7552
jupyterlab · Jan 28, 2020 · 6433521 · 6433521
2 parents 3cb64ca + 83b3eca
commit 6433521
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 9 deletions.
diff --git a/packages/docmanager-extension/src/index.ts b/packages/docmanager-extension/src/index.ts
@@ -486,16 +486,25 @@ function addCommands(
           buttons: [Dialog.okButton()]
         });
       }
-      return showDialog({
-        title: `Reload ${type} from Disk`,
-        body: `Are you sure you want to reload
+      if (context.model.dirty) {
+        return showDialog({
+          title: `Reload ${type} from Disk`,
+          body: `Are you sure you want to reload
           the ${type} from the disk?`,
-        buttons: [Dialog.cancelButton(), Dialog.warnButton({ label: 'Reload' })]
-      }).then(result => {
-        if (result.button.accept && !context.isDisposed) {
+          buttons: [
+            Dialog.cancelButton(),
+            Dialog.warnButton({ label: 'Reload' })
+          ]
+        }).then(result => {
+          if (result.button.accept && !context.isDisposed) {
+            return context.revert();
+          }
+        });
+      } else {
+        if (!context.isDisposed) {
           return context.revert();
         }
-      });
+      }
     }
   });
 

diff --git a/packages/htmlviewer/src/index.tsx b/packages/htmlviewer/src/index.tsx
@@ -90,8 +90,11 @@ export class HTMLViewer extends DocumentWidget<IFrame>
       'refresh',
       new ToolbarButton({
         iconRenderer: refreshIcon,
-        onClick: () => {
-          this.content.url = this.content.url;
+        onClick: async () => {
+          if (!this.context.model.dirty) {
+            await this.context.revert();
+            this.update();
+          }
         },
         tooltip: 'Rerender HTML Document'
       })