Add a sourceChanged signal and use it to notify of command changes.

jupyterlab · Oct 17, 2019 · 77354b5 · 77354b5
1 parent 2afb2ae
commit 77354b5
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 2 deletions.
diff --git a/packages/logconsole-extension/src/index.tsx b/packages/logconsole-extension/src/index.tsx
@@ -488,8 +488,13 @@ function activateLogConsole(
       return true;
     });
 
+    logConsolePanel.sourceChanged.connect(() => {
+      app.commands.notifyCommandChanged();
+    });
+
     logConsoleWidget.disposed.connect(() => {
       logConsoleWidget = null;
+      app.commands.notifyCommandChanged();
       status.model.flashEnabled = flashEnabled;
     });
 
@@ -499,6 +504,7 @@ function activateLogConsole(
     });
 
     logConsoleWidget.update();
+    app.commands.notifyCommandChanged();
   };
 
   app.commands.addCommand(CommandIDs.open, {

diff --git a/packages/logconsole/src/widget.ts b/packages/logconsole/src/widget.ts
@@ -451,13 +451,21 @@ export class LogConsolePanel extends StackedPanel {
   /**
    * The log source displayed
    */
-  get source(): string {
+  get source(): string | null {
     return this._source;
   }
-  set source(name: string) {
+  set source(name: string | null) {
     this._source = name;
     this._showOutputFromSource(this._source);
     this._handlePlaceholder();
+    this._sourceChanged.emit(name);
+  }
+
+  /**
+   * Signal for source changes
+   */
+  get sourceChanged(): ISignal<this, string | null> {
+    return this._sourceChanged;
   }
 
   private _handlePlaceholder() {
@@ -554,6 +562,7 @@ export class LogConsolePanel extends StackedPanel {
   private _loggerRegistry: ILoggerRegistry;
   private _outputAreas = new Map<string, LogConsoleOutputArea>();
   private _source: string | null = null;
+  private _sourceChanged = new Signal<this, string | null>(this);
   private _entryLimit: number = DEFAULT_LOG_ENTRY_LIMIT;
   private _scrollTimer: number = null;
   private _placeholder: Widget;