Allow metadata for launcher items

integrity
jupyterlab · Dec 23, 2019 · 7e2c254 · 7e2c254
1 parent 72d9e17
commit 7e2c254
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 4 deletions.
diff --git a/packages/console-extension/src/index.ts b/packages/console-extension/src/index.ts
@@ -181,7 +181,8 @@ async function activateConsole(
         let baseUrl = PageConfig.getBaseUrl();
         for (let name in specs.kernelspecs) {
           let rank = name === specs.default ? 0 : Infinity;
-          let kernelIconUrl = specs.kernelspecs[name]?.resources['logo-64x64'];
+          const spec = specs.kernelspecs[name]!;
+          let kernelIconUrl = spec.resources['logo-64x64'];
           if (kernelIconUrl) {
             let index = kernelIconUrl.indexOf('kernelspecs');
             kernelIconUrl = URLExt.join(baseUrl, kernelIconUrl.slice(index));
@@ -192,7 +193,8 @@ async function activateConsole(
               args: { isLauncher: true, kernelPreference: { name } },
               category: 'Console',
               rank,
-              kernelIconUrl
+              kernelIconUrl,
+              metadata: spec.metadata
             })
           );
         }

diff --git a/packages/launcher/src/index.tsx b/packages/launcher/src/index.tsx
@@ -344,6 +344,12 @@ export namespace ILauncher {
      * spec.
      */
     kernelIconUrl?: string;
+
+    /**
+     * Metadata about the item.  This can be used by the launcher to
+     * affect how the item is displayed.
+     */
+    metadata?: ReadonlyJSONObject;
   }
 }
 

diff --git a/packages/notebook-extension/src/index.ts b/packages/notebook-extension/src/index.ts
@@ -725,7 +725,8 @@ function activateNotebookHandler(
 
         for (let name in specs.kernelspecs) {
           let rank = name === specs.default ? 0 : Infinity;
-          let kernelIconUrl = specs.kernelspecs[name]?.resources['logo-64x64'];
+          const spec = specs.kernelspecs[name]!;
+          let kernelIconUrl = spec.resources['logo-64x64'];
           if (kernelIconUrl) {
             let index = kernelIconUrl.indexOf('kernelspecs');
             kernelIconUrl = URLExt.join(baseUrl, kernelIconUrl.slice(index));
@@ -736,7 +737,8 @@ function activateNotebookHandler(
               args: { isLauncher: true, kernelName: name },
               category: 'Notebook',
               rank,
-              kernelIconUrl
+              kernelIconUrl,
+              metadata: spec.metadata
             })
           );
         }