Merge pull request #6838 from domoritz/finalize2

Finalize Vega view before creating a new one
jupyterlab · Jul 19, 2019 · 84539f1 · 84539f1
2 parents 5c46ce6 + fd28d0a
commit 84539f1
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/packages/vega4-extension/src/index.ts b/packages/vega4-extension/src/index.ts
@@ -85,6 +85,10 @@ export class RenderedVega extends Widget implements IRenderMime.IRenderer {
     this.node.textContent = '';
     this.node.appendChild(el);
 
+    if (this._result) {
+      this._result.view.finalize();
+    }
+
     this._result = await vega.default(el, spec, {
       actions: true,
       defaultStyle: true,

diff --git a/packages/vega5-extension/src/index.ts b/packages/vega5-extension/src/index.ts
@@ -85,6 +85,10 @@ export class RenderedVega extends Widget implements IRenderMime.IRenderer {
     this.node.textContent = '';
     this.node.appendChild(el);
 
+    if (this._result) {
+      this._result.view.finalize();
+    }
+
     this._result = await vega.default(el, spec, {
       actions: true,
       defaultStyle: true,