Skip to content

Commit

Permalink
Merge pull request #7603 from fcollonval/force-browser-tab
Browse files Browse the repository at this point in the history
Optionnaly force new browser tab
  • Loading branch information
Steven Silvester committed Dec 9, 2019
2 parents d721469 + 9b78e46 commit a1fc14a
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion packages/help-extension/src/index.tsx
Expand Up @@ -361,9 +361,13 @@ function activate(
execute: args => {
const url = args['url'] as string;
const text = args['text'] as string;
const newBrowserTab = (args['newBrowserTab'] as boolean) || false;

// If help resource will generate a mixed content error, load externally.
if (LAB_IS_SECURE && URLExt.parse(url).protocol !== 'https:') {
if (
newBrowserTab ||
(LAB_IS_SECURE && URLExt.parse(url).protocol !== 'https:')
) {
window.open(url);
return;
}
Expand Down

0 comments on commit a1fc14a

Please sign in to comment.