Merge pull request #8032 from jasongrout/futuredone

Make IFuture done typings more correct
jupyterlab · Mar 12, 2020 · a29398a · a29398a
2 parents 83d8388 + 2f18043
commit a29398a
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/packages/services/src/kernel/kernel.ts b/packages/services/src/kernel/kernel.ts
@@ -685,10 +685,9 @@ export interface IFuture<
    * The future is done when there are no more responses expected from the
    * kernel.
    *
-   * The `done` promise resolves to the reply message if there is one,
-   * otherwise it resolves to `undefined`.
+   * The `done` promise resolves to the reply message.
    */
-  readonly done: Promise<REPLY | undefined>;
+  readonly done: Promise<REPLY>;
 
   /**
    * The reply handler for the kernel future.