Strict null handling

jupyterlab · Dec 23, 2019 · b273d31 · b273d31
1 parent c26c8cc
commit b273d31
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/packages/console-extension/src/index.ts b/packages/console-extension/src/index.ts
@@ -40,7 +40,7 @@ import { IRenderMimeRegistry } from '@jupyterlab/rendermime';
 
 import { find } from '@lumino/algorithm';
 
-import { JSONObject, ReadonlyPartialJSONObject, UUID } from '@lumino/coreutils';
+import { JSONExt, JSONObject, ReadonlyPartialJSONObject, UUID, ReadonlyJSONValue } from '@lumino/coreutils';
 
 import { DisposableSet } from '@lumino/disposable';
 
@@ -194,7 +194,7 @@ async function activateConsole(
               category: 'Console',
               rank,
               kernelIconUrl,
-              metadata: { kernel: spec.metadata }
+              metadata: { kernel: JSONExt.deepCopy(spec.metadata || {}) as ReadonlyJSONValue }
             })
           );
         }

diff --git a/packages/notebook-extension/src/index.ts b/packages/notebook-extension/src/index.ts
@@ -32,7 +32,7 @@ import { IDocumentManager } from '@jupyterlab/docmanager';
 
 import { ArrayExt } from '@lumino/algorithm';
 
-import { UUID, JSONObject, ReadonlyPartialJSONObject } from '@lumino/coreutils';
+import { UUID, JSONExt, JSONObject, ReadonlyPartialJSONObject, ReadonlyJSONValue } from '@lumino/coreutils';
 
 import { DisposableSet } from '@lumino/disposable';
 
@@ -738,7 +738,7 @@ function activateNotebookHandler(
               category: 'Notebook',
               rank,
               kernelIconUrl,
-              metadata: { kernel: spec.metadata }
+              metadata: { kernel: JSONExt.deepCopy(spec.metadata || {}) as ReadonlyJSONValue }
             })
           );
         }