misc uncertainties

jupyterlab · Dec 20, 2019 · cf623f1 · cf623f1
1 parent 56bbec9
commit cf623f1
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 4 deletions.
diff --git a/packages/codemirror-extension/src/index.ts b/packages/codemirror-extension/src/index.ts
@@ -348,7 +348,7 @@ function activateEditorCommands(
       }
       modeMenu.addItem({
         command: CommandIDs.changeMode,
-        args: { ...spec }
+        args: { ...spec } as any // TODO: Casting to `any` until lumino typings are fixed
       });
     });
 

diff --git a/packages/completer/src/model.ts b/packages/completer/src/model.ts
@@ -482,7 +482,10 @@ namespace Private {
   export function findOrderedTypes(typeMap: Completer.TypeMap): string[] {
     const filtered = Object.keys(typeMap)
       .map(key => typeMap[key])
-      .filter(value => value && !(value in KNOWN_MAP))
+      .filter(
+        (value: string | null): value is string =>
+          !!value && !(value in KNOWN_MAP)
+      )
       .sort((a, b) => a.localeCompare(b));
 
     return KNOWN_TYPES.concat(filtered);

diff --git a/packages/settingeditor/src/pluginlist.tsx b/packages/settingeditor/src/pluginlist.tsx
@@ -53,8 +53,8 @@ export class PluginList extends Widget {
   /**
    * The selection value of the plugin list.
    */
-  get scrollTop(): number {
-    return this.node.querySelector('ul').scrollTop;
+  get scrollTop(): number | undefined {
+    return this.node.querySelector('ul')?.scrollTop;
   }
 
   /**