Merge pull request #6604 from jupyterlab/showerror-cleanup

Cleanup showErrorMessage
jupyterlab · Jun 20, 2019 · d3515a2 · d3515a2
2 parents c952a47 + f11df02
commit d3515a2
Showing 1 changed file with 10 additions and 3 deletions.
diff --git a/packages/apputils/src/dialog.ts b/packages/apputils/src/dialog.ts
@@ -60,9 +60,16 @@ export function showErrorMessage(
       title: title,
       body: body,
       buttons: buttons
-    }).then(() => {
-      Private.errorMessagePromiseCache.delete(key);
-    });
+    }).then(
+      () => {
+        Private.errorMessagePromiseCache.delete(key);
+      },
+      error => {
+        // TODO: Use .finally() above when supported
+        Private.errorMessagePromiseCache.delete(key);
+        throw error;
+      }
+    );
     Private.errorMessagePromiseCache.set(key, dialogPromise);
     return dialogPromise;
   }