Merge pull request #7061 from blink1073/fix-pageconfig

Fix handling of page config for non-strings
jupyterlab · Aug 21, 2019 · e7df370 · e7df370
2 parents 8f16ca8 + eac4cfb
commit e7df370
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/packages/coreutils/src/pageconfig.ts b/packages/coreutils/src/pageconfig.ts
@@ -79,10 +79,10 @@ export namespace PageConfig {
       configData = Object.create(null);
     } else {
       for (let key in configData) {
-        // Quote characters are escaped, unescape them.
-        configData[key] = String(configData[key])
-          .split('&#39;')
-          .join('"');
+        // PageConfig expects strings
+        if (typeof configData[key] !== 'string') {
+          configData[key] = JSON.stringify(configData[key]);
+        }
       }
     }
     return configData![name] || Private.getBodyData(name);