Skip to content

Commit

Permalink
Skip running npm pack on windows
Browse files Browse the repository at this point in the history
  • Loading branch information
saulshanabrook committed Aug 7, 2019
1 parent 1ef8937 commit f269cc0
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions jupyterlab/tests/test_jupyterlab.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
import subprocess
import shutil
import pathlib
import platform
from os.path import join as pjoin
from tempfile import TemporaryDirectory
from unittest import TestCase
Expand Down Expand Up @@ -233,7 +234,6 @@ def test_uninstall_core_extension(self):
assert '@jupyterlab/console-extension' in extensions
assert check_extension('@jupyterlab/console-extension')

@pytest.mark.webtest
def test_install_and_uninstall_pinned(self):
"""
You should be able to install different versions of the same extension with different
Expand All @@ -259,8 +259,7 @@ def test_install_and_uninstall_pinned(self):
assert not check_extension(NAMES[0])
assert not check_extension(NAMES[1])


@pytest.mark.webtest
@pytest.mark.skipif(platform.system() == 'Windows', reason='running npm pack fails on windows CI')
def test_install_and_uninstall_pinned_folder(self):
"""
Same as above test, but installs from a local folder instead of from npm.
Expand All @@ -286,6 +285,7 @@ def test_install_and_uninstall_pinned_folder(self):
self.pinned_packages = [str(base_dir / '1' / 'package'), str(base_dir / '2' / 'package')]
self.test_install_and_uninstall_pinned()


def test_link_extension(self):
path = self.mock_extension
name = self.pkg_names['extension']
Expand Down

0 comments on commit f269cc0

Please sign in to comment.