Merge pull request #6628 from ellisonbg/broken-faq

Remove the FAQ extension
jupyterlab · Jun 19, 2019 · fd18d01 · fd18d01
2 parents eb0c1b7 + 22bc8eb
commit fd18d01
Show file tree

Hide file tree

Showing 17 changed files with 4 additions and 269 deletions.
diff --git a/buildutils/src/ensure-repo.ts b/buildutils/src/ensure-repo.ts
@@ -52,7 +52,6 @@ let SKIP_CSS: Dict<string[]> = {
   ],
   '@jupyterlab/filebrowser': ['@jupyterlab/statusbar'],
   '@jupyterlab/fileeditor': ['@jupyterlab/statusbar'],
-  '@jupyterlab/faq-extension': ['@jupyterlab/application'],
   '@jupyterlab/help-extension': ['@jupyterlab/application'],
   '@jupyterlab/shortcuts-extension': ['@jupyterlab/application'],
   '@jupyterlab/tabmanager-extension': ['@jupyterlab/application'],

diff --git a/dev_mode/imports.css b/dev_mode/imports.css
@@ -9,7 +9,6 @@
 @import url('~@jupyterlab/docmanager-extension/style/index.css');
 @import url('~@jupyterlab/documentsearch-extension/style/index.css');
 @import url('~@jupyterlab/extensionmanager-extension/style/index.css');
-@import url('~@jupyterlab/faq-extension/style/index.css');
 @import url('~@jupyterlab/filebrowser-extension/style/index.css');
 @import url('~@jupyterlab/fileeditor-extension/style/index.css');
 @import url('~@jupyterlab/help-extension/style/index.css');

diff --git a/dev_mode/package.json b/dev_mode/package.json
@@ -27,7 +27,6 @@
     "@jupyterlab/documentsearch-extension": "^1.0.0-alpha.13",
     "@jupyterlab/extensionmanager": "^1.0.0-alpha.11",
     "@jupyterlab/extensionmanager-extension": "^1.0.0-alpha.11",
-    "@jupyterlab/faq-extension": "^1.0.0-alpha.11",
     "@jupyterlab/filebrowser": "^1.0.0-alpha.11",
     "@jupyterlab/filebrowser-extension": "^1.0.0-alpha.11",
     "@jupyterlab/fileeditor": "^1.0.0-alpha.11",
@@ -126,7 +125,6 @@
       "@jupyterlab/docmanager-extension": "",
       "@jupyterlab/documentsearch-extension": "",
       "@jupyterlab/extensionmanager-extension": "",
-      "@jupyterlab/faq-extension": "",
       "@jupyterlab/filebrowser-extension": "",
       "@jupyterlab/fileeditor-extension": "",
       "@jupyterlab/help-extension": "",
@@ -222,7 +220,6 @@
       "@jupyterlab/docmanager-extension": "../packages/docmanager-extension",
       "@jupyterlab/documentsearch-extension": "../packages/documentsearch-extension",
       "@jupyterlab/extensionmanager-extension": "../packages/extensionmanager-extension",
-      "@jupyterlab/faq-extension": "../packages/faq-extension",
       "@jupyterlab/filebrowser-extension": "../packages/filebrowser-extension",
       "@jupyterlab/fileeditor-extension": "../packages/fileeditor-extension",
       "@jupyterlab/help-extension": "../packages/help-extension",

diff --git a/examples/app/package.json b/examples/app/package.json
@@ -17,7 +17,6 @@
     "@jupyterlab/console-extension": "^1.0.0-alpha.11",
     "@jupyterlab/csvviewer-extension": "^1.0.0-alpha.12",
     "@jupyterlab/docmanager-extension": "^1.0.0-alpha.11",
-    "@jupyterlab/faq-extension": "^1.0.0-alpha.11",
     "@jupyterlab/filebrowser-extension": "^1.0.0-alpha.11",
     "@jupyterlab/fileeditor-extension": "^1.0.0-alpha.11",
     "@jupyterlab/help-extension": "^1.0.0-alpha.11",

diff --git a/packages/faq-extension/README.md b/packages/faq-extension/README.md
diff --git a/packages/faq-extension/faq.md b/packages/faq-extension/faq.md
diff --git a/packages/faq-extension/package.json b/packages/faq-extension/package.json
diff --git a/packages/faq-extension/src/index.ts b/packages/faq-extension/src/index.ts
diff --git a/packages/faq-extension/style/base.css b/packages/faq-extension/style/base.css
diff --git a/packages/faq-extension/style/index.css b/packages/faq-extension/style/index.css
diff --git a/packages/faq-extension/tdoptions.json b/packages/faq-extension/tdoptions.json
diff --git a/packages/faq-extension/tsconfig.json b/packages/faq-extension/tsconfig.json
diff --git a/packages/help-extension/src/index.tsx b/packages/help-extension/src/index.tsx
@@ -153,11 +153,9 @@ function activate(
 
   // Populate the Help menu.
   const helpMenu = mainMenu.helpMenu;
-  const labGroup = [
-    CommandIDs.about,
-    'faq-jupyterlab:open',
-    CommandIDs.launchClassic
-  ].map(command => ({ command }));
+  const labGroup = [CommandIDs.about, CommandIDs.launchClassic].map(
+    command => ({ command })
+  );
   helpMenu.addGroup(labGroup, 0);
   const resourcesGroup = RESOURCES.map(args => ({
     args,

diff --git a/packages/inspector/src/handler.ts b/packages/inspector/src/handler.ts
@@ -167,7 +167,7 @@ export class InspectionHandler implements IDisposable, IInspector.IInspectable {
    * Handle changes to the editor state, debouncing.
    */
   private _onChange(): void {
-    this._debouncer.invoke();
+    void this._debouncer.invoke();
   }
 
   private _cleared = new Signal<InspectionHandler, void>(this);

diff --git a/packages/metapackage/package.json b/packages/metapackage/package.json
@@ -54,7 +54,6 @@
     "@jupyterlab/documentsearch-extension": "^1.0.0-alpha.13",
     "@jupyterlab/extensionmanager": "^1.0.0-alpha.11",
     "@jupyterlab/extensionmanager-extension": "^1.0.0-alpha.11",
-    "@jupyterlab/faq-extension": "^1.0.0-alpha.11",
     "@jupyterlab/filebrowser": "^1.0.0-alpha.11",
     "@jupyterlab/filebrowser-extension": "^1.0.0-alpha.11",
     "@jupyterlab/fileeditor": "^1.0.0-alpha.11",

diff --git a/packages/metapackage/src/index.ts b/packages/metapackage/src/index.ts
@@ -22,7 +22,6 @@ import '@jupyterlab/docmanager-extension';
 import '@jupyterlab/docregistry';
 import '@jupyterlab/extensionmanager';
 import '@jupyterlab/extensionmanager-extension';
-import '@jupyterlab/faq-extension';
 import '@jupyterlab/filebrowser';
 import '@jupyterlab/filebrowser-extension';
 import '@jupyterlab/fileeditor';

diff --git a/packages/metapackage/tsconfig.json b/packages/metapackage/tsconfig.json
@@ -75,9 +75,6 @@
     {
       "path": "../extensionmanager-extension"
     },
-    {
-      "path": "../faq-extension"
-    },
     {
       "path": "../filebrowser"
     },