"Search Cell Outputs" Find/Replace is disabled when Replace is expanded, without an indication why

[vitorlppf]

While using the Find/Replace feature I came across the following bug: the "Search Cell Outputs" can't be toggled while the Replace submenu is active. In principle, this is reasonable, as you can't replace the output of a cell. However, if the toggle was active before using the submenu (as is the default) the Find still searches and returns cell output. Thus you have to deactivate the Replace submenu in order to toggle the option off, and then resume trying to Find and Replace cell inputs.

I propose the toggle should be overridden and set to not search cell output while the Replace submenu is active, and return to the last toggled value after the submenu is deactivated.

I found this old issue which coincidentally includes a GIF depicting the described behaviour. Note how the "Search Cell Outputs" toggle turns grey once the Replace submenu is activated.

Hi @LuckyMD this was implemented in #10067 and is included in JupyterLab 3.1 which is now in release candidate phase (please help testing it if you would like to try out this feature). Example:

Originally posted by @krassowski in #6650 (comment)

[welcome]

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively.

You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

[krassowski]

Related to #6650

[fcollonval]

For information this will be corrected in JupyterLab 4 - screencast below taken from JupyterLab 4.0.0a29

[JasonWeill]

I can confirm that the "search cell outputs" filter is disabled in Lab 4, but it's not clear why this filter is disabled. This could be improved by, for example, modifying the tooltip to explain that the user can't search cell outputs when the "replace" options are shown.