Adds description for disabled search filter #15867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for making a pull request to jupyterlab! |
krassowski
reviewed
Feb 27, 2024
|
Restarting the UI tests, not sure if the failures are relevant or just flaky. |
Out of curiosity I restarted the UI tests 4 times, until they passed:
So it looks like there are still improvements to be done to the UI tests flakiness in general to reduce maintenance load. Maybe #15375 will help with that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Fixes #13167.
Code changes
Adds a "disabled description" field to search filters, to provide an alternate description when the filter is disabled in "find and replace" mode.
User-facing changes
When the user is in "find and replace" mode and opens the filter options in the search box, the "search cell outputs" filter is disabled. Mousing over it now displays an alternate title:
Backwards-incompatible changes
None.