New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Find and replace within a single cell #2017
Comments
We would like to implement a generic search and replace extension that can have multiple UIs attached to it to provide per cell, per document and per directory search and replace. This should use such a service. |
Big +1 on this! There is a 'find' and 'find and replace' menu option in lab, but I can't work out how to make them active - in what context are these usable? This is an everyday feature for me in notebook, and enough for me to not use lab for day-to-day. Is there anywhere I can read to get context on why this would be supported via an extension and not as a core feature? |
I agree. My understanding is the plan is to have this in core by 1.0, for the notebook and text editor, but to make it extensible so other widgets can also define how it's handled in their context. |
@saulshanabrook - are you still hoping to do this for 1.0, or Future? |
Future for me. If anyone else is planning to do it for 1.0 feel free to move it back. |
I was able to find a "search-and-replace" functionality from looking into CodeMirror. I'm not sure if you guys are planning on writing something different, but for those who are still looking for a "search-and-replace", pressing |
Thanks for posting the helpful tip. The new prerelease we just released has a new Find functionality that works in notebooks (thanks again @aschlaep!). We're planning on expanding that to have replacement functionality too. |
Find and Replace was introduced in 1.0 and there are some problems with performance in large notebooks #6756 A feature to limit the scope to one/manually selected number of cells could be a part of solution. |
Seems we still don't have this functionality in version 1.1.4? |
Nor in 1.2.1, the most recent release. Contributions and help implementing this is welcome! |
Hi! I would like to contribute to this issue. Can someone please add me as an assignee to this issue? |
Sure! Just did. If you are around, feel free to come to our weekly meeting as well to say hi and let people know what you are working on (not in any way required, just if you want). |
Hi all! |
Great, thanks @AlbertHilb! |
Any updates on this? Replace within selected cells is a pretty important part of my workflow. Would be nice to have it now that I've moved to Lab from Classic. |
This is the whole reason why I dont use Labs, i.e. the lack of this feature! |
Seriously, no find and replace? Glad I'm leaving the tech industry shortly. |
@bjoernmeier broader rants about the tech industry are not appropriate on this repo, please keep your comments to the issue at hand. Clarification - JupyterLab does have find and replace, both the one-by-one and replace all variant. The issue here is discussing an additional variant that has a scope of the selected cells. This is a gap relative to the classic notebook that we should close. |
Started using jupyterlab yesterday. Realized there is no 'F' find and replace functionality in it. Moving back to jupyter as I'm an extensive user of this feature. I will check every 6 months to see if it is there but given this issue was opened in march 2017 and still, the issue hasn't been resolved, I don't hope much. |
Wanting to find and replace within a cell would not be that exceptional of a use case though. Maybe some ranting is needed to get things moving here. |
Agreed. This is a quite basic feature that should be part of the default toolkit. If I was not forced to use JuypterLab at work I'd go with VSCode or similar. Replace in selection/cell etc. so much better. |
Is there a technical blocker on this or just not a priority relative to other work? If the latter, what can we in the community do to increase the priority? Just +1 the ticket? |
This (you can see the many calls above for help from the community to implement this, for example.)
There are already lots of people +1ing this ticket. The best way to actually move this forward is to work on a PR implementing it. |
@AlbertHilb - it looks like you started working on this. Did you make any progress you could share, even if it's not fully implemented? |
please, i'd love to have the 'F' functionality in jupyterlab |
I love JupyterLab! But I'd really like to have this feature. |
+1 |
1 similar comment
+1 |
I see we have an image in the changelog (https://jupyterlab.readthedocs.io/en/stable/getting_started/changelog.html?highlight=replace#find-and-replace), but not in the docs. It sounds like this animation maybe would be good to add to the user docs somewhere. |
So, In conclusion, we still do not have |
Update: we are tracking this issue on the JupyterLab 4.0 roadmap that we
are working on, but at this point, there isn't anyone who has indicated
they have cycles to work on it.
…On Sat, Apr 3, 2021 at 5:48 AM Travis ***@***.***> wrote:
So, In conclusion, we still do not have an find and repalace within ceil
in jupyter lab?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#2017 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAGXUGLIJ4BUXKCIPTORALTG4FDHANCNFSM4DF7ZUWQ>
.
--
Brian E. Granger
Principal Technical Program Manager, AWS AI Platform ***@***.***)
On Leave - Professor of Physics and Data Science, Cal Poly
@ellisonbg on GitHub
|
Here is a workaround that exposes the CodeMirror single-cell find/replace for those that need search/replace in a cell, which will work until someone can contribute single-cell find/replace to the main jlab searching.
{
shortcuts: [
{
command: "documentsearch:start",
keys: ["Accel F"],
selector: ".jp-mod-searchable",
disabled: true,
},
{
command: "documentsearch:start",
// Choose a shortcut. Here we set it to shift ctrl/cmd F, which conflicts with the file browser shortcut,
// so you may want to choose something else
keys: ["Shift Accel F"],
selector: ".jp-mod-searchable",
},
]
}
|
I don't think Github sends out notification when a related PR is merged, but wanted to let those of you subscribed to this ticket know that with #10067 merged 2 weeks ago, the ability to search (and replace) within an active selection of cells will be available in JupyterLab 3.1, which hasn't been released yet, but you can install the pre-release if you're feeling adventurous. |
Closing :) |
In addition to having a "find and replace" for the entire notebook (#1074), it would be nice to have a "find and replace" within a single cell. This could be a separate hot-key command, or perhaps it could be a check-box in the document wide "find and replace", to select only the active cell. I have often wished something like this was available in the classic notebooks.
The text was updated successfully, but these errors were encountered: