Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delimiters support for hash #6324

Closed
rolandettema opened this issue May 8, 2019 · 2 comments · Fixed by #7367
Closed

delimiters support for hash #6324

rolandettema opened this issue May 8, 2019 · 2 comments · Fixed by #7367
Labels
good first issue status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Milestone

Comments

@rolandettema
Copy link

The current delimiters supported in the dropdown for table view of CSV are commas, semicolons, tab and pipe. Is there interest in supporting hash (#) delimitation?

@jasongrout
Copy link
Contributor

If you see files like this, feel free to add it. I didn't have it in there because I've never seen that delimiter in the wild.

The code is at

/**
* The supported parsing delimiters.
*/
const DELIMITERS = [',', ';', '\t', '|'];
/**
* The labels for each delimiter as they appear in the dropdown menu.
*/
const LABELS = [',', ';', 'tab', 'pipe'];

@jasongrout jasongrout added this to the Future milestone May 8, 2019
@jasongrout
Copy link
Contributor

(just curious, where do you see files with hash delimiters?)

@lock lock bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Nov 14, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Nov 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants