Added hash to the csv delimiter types

[dkapila]

References

Fixes #6324

Code changes

Updated toolbar.js to add '#' as a possible combination.

User-facing changes

Users can select hash as a possible delimiter.

Backwards-incompatible changes

None.

[jupyterlab-dev-mode]

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link:

[jtpio]

Changes look good, thanks!

I agree this delimiter doesn't seem to be used often (as stated in #6324), but it can still be useful to have it available.

Leaving it open for a while in case someone has an objection.

[jtpio]

Test failure is not relevant (docs link check failing).

[jasongrout]

Thanks! How does this behave with the anchor references to a cell in a datagrid?

[some link in markdown](./test.csv#row=4)

(It shouldn't change anything, but just making sure...)

[dkapila]

@jasongrout

This is what we get:

What do you think the expected behaviour should be?

[jasongrout]

This is what we get:

Well, for one it shouldn't modify the file at all

Two: Can you try with a file that has at least 4 rows? What should happen is something like in the example in #5727

[jasongrout]

This is what we get:

Ah, just noticed your link is the same file. I meant:

1. Create a test.csv file with hash delimiters, with at least 4 rows
2. Create a markdown file next to it with the link [some link in markdown](./test.csv#row=4)
3. Close the csv file
4. Click the link - should open the file, but may be messed up because the delimiter is not set?
5. Set the delimiter and click the link again
6. Row 4 should be highlighted.

[dkapila]

@jasongrout

Thanks, I've tested the steps using hash, above and it works as expected.

[jasongrout]

Thanks!

[jtpio]

Thanks @dkapila and congrats on your first contribution!