requestCommInfo not honoring target name

[kb0304]

Describe the bug
When developing an extension which sends custom comm messages, and with ipywidgets' jupyterlab-manager installed, the messages even with target other than jupyter.widget are being intercepted by jupyterlab-manager

Why the requestCommInfo is not honoring target name here?

Expected behavior
Messages only with target jupyter.widget are intercepted

• Browser [chrome ]
• JupyterLab [1.0.2]
• @jupyter-widgets/jupyterlab-manager@1.0.1

[kb0304]

Turns out they're using target here instead of target_name
const reply = await this._context.session.kernel.requestCommInfo({target: this.comm_target_name});

[jasongrout]

c.f. jupyter-widgets/ipywidgets#2526

[jasongrout]

Thanks for finding and reporting this, and finding the underlying cause. Let's move the discussion over to the ipywidgets issue, since that's where the problem is.

[Madhu94]

@jasongrout I believe the KernelMessage type should be fixed in lab first - here, before you could fix ipywidgets (TS errors may surface)

[Madhu94]

If we change the type, would that constitute a breaking change for the services package? If so, could renaming target to target_name here may be a quicker temporary fix?

[jasongrout]

@jasongrout I believe the KernelMessage type should be fixed in lab first - here, before you could fix ipywidgets (TS errors may surface)

Good catch. This is deeper than I thought.

If we change the type, would that constitute a breaking change for the services package?

Technically, yes, but it's also a pretty clear bug-fix, in that it is not following the spec.

[jasongrout]

What do you think of #6949 ?

[Madhu94]

This is exactly what I meant when I said "renaming it can be a quick fix". Poorly worded I guess. :) Thanks for fixing it !

…

On Tue, 6 Aug 2019, 00:01 Jason Grout, ***@***.***> wrote: What do you think of #6949 <#6949> ? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#6947?email_source=notifications&email_token=ACEZEDCTZ5MNXYFO3H5QPZLQDBWY3A5CNFSM4IJKUAO2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3SVXKQ#issuecomment-518347690>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACEZEDGYWKIZ5KUOBIV4VR3QDBWY3ANCNFSM4IJKUAOQ> .