Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show file-size in File browser #7352

Closed
stefansimik opened this issue Oct 13, 2019 · 3 comments · Fixed by #7485
Closed

Show file-size in File browser #7352

stefansimik opened this issue Oct 13, 2019 · 3 comments · Fixed by #7485
Labels
enhancement good first issue pkg:filebrowser status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Milestone
2.0

Comments

@stefansimik
Copy link
Contributor

stefansimik commented Oct 13, 2019 •
edited

Hi,
I believe developers are frequently looking for the size of the files in File Browser.
One simply needs to to see how big are input *.csv files, *.pickle files or many other.
One still has to switch to the OS file-browser, to see this very basic information.

Would you find it useful to add and display this information in the FileBrowser?

Note:
I could not find any plugin/extension, that could do this.
But is it generally useful basic thing, that this feature should be standard part of JupyterLab interface.
@blink1073
Copy link
Member

Hi @stefansimik, that sounds like a great idea to me! I think at a minimum we should add some info as an HTML title here using the model info. We do something similar for document tabs here.
Docs on the IModel interface.

Is this something you wanted to work on?

@stefansimik
Copy link
Contributor Author

stefansimik commented Oct 15, 2019 •
edited

Hi @blink1073 , thank you for you support.
I am heavy user and proud promoter of JupyterLab in my courses, but I am just newbie in Javascript / related technologies. Anyway, if I could be of any other help, I am ready ;)

@blink1073
Copy link
Member

Fair enough, thanks for the feedback!

@blink1073 blink1073 added this to the 2.0 milestone Oct 15, 2019
macwoj pushed a commit to macwoj/jupyterlab that referenced this issue Nov 6, 2019
Adding file size to File browser hover
90704e5 
Fixes jupyterlab#7352
@macwoj macwoj mentioned this issue Nov 6, 2019
Merged
macwoj pushed a commit to macwoj/jupyterlab that referenced this issue Nov 9, 2019
Adding path, size, created/mod to hover
ad4d929 
Fixes jupyterlab#7352
macwoj pushed a commit to macwoj/jupyterlab that referenced this issue Nov 10, 2019
changed time format to YYYY-MM-DD HH:mm:ss
322a872 
only show directory in Path

Fixes jupyterlab#7352
@lock lock bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Dec 11, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Dec 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement good first issue pkg:filebrowser status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Milestone
2.0
Development

Successfully merging a pull request may close this issue.

Adding file size to File browser hover macwoj/jupyterlab
2 participants
@blink1073 @stefansimik