Adding file size to File browser hover #7485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for making a pull request to JupyterLab! To try out this branch on binder, follow this link: |
blink1073
reviewed
Nov 7, 2019
packages/filebrowser/src/listing.ts
Outdated
| @@ -1833,8 +1833,13 @@ export namespace DirListing { | |||
| // clean up the svg icon annotation, if any | |||
| delete icon.dataset.icon; | |||
| } | |||
| // add file size to pop up if its available | |||
| if (model.size !== null && model.size !== undefined) { | |||
| node.title = model.name + ' - ' + Private.formatFileSize(model.size, 1); | |||
There was a problem hiding this comment.
Thanks for adding this! I think it looks too sparse without adding more info. I think we should show the following:
Name: foo.bar
Size: as you have it
Path: path limited to 50 chars with an ellipsis if longer
Created: Formatted using Time.format.
Modified: Same as above
Similar to what Finder shows on MacOS about a file:
There was a problem hiding this comment.
And just not show the size part if we don't have it.
There was a problem hiding this comment.
Yeah that looks better. Let me fix it.
added 2 commits
November 9, 2019 00:18
only show directory in Path Fixes jupyterlab#7352
|
Perfect, thanks again @macwoj! |
lock
bot
added
the
status:resolved-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Fixes #7352
Code changes
added size field to the Contents.IModel
added more file context to title in updateItemNode (filebrowser/src/listing.ts)
User-facing changes
Hover in file vrowser will now show.
Name:
Size: If available the human readable file size with a single decimal.
Path: only the directory limited to 50
Created: YYYY-MM-DD HH:mm:ss
Modified: YYYY-MM-DD HH:mm:ss
Backwards-incompatible changes
added new field which is optional so no backwards compatibility issues.