Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dark mode not working in 2.0.0a3 #7610

Closed
tgeorgeux opened this issue Dec 10, 2019 · 3 comments
Closed

Dark mode not working in 2.0.0a3 #7610

tgeorgeux opened this issue Dec 10, 2019 · 3 comments
Labels
bug pkg:themes status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Milestone
2.0

Comments

@tgeorgeux
Copy link
Contributor

Description

I was working in 2.0.0a3 dev mode and the toggle for 'Use JupyterLab Dark Theme' isn't working in the command palette or in the settings menu.

Reproduce

  1. Clone JupyterLab
  2. Install and Build.
  3. Run jupyter lab --dev-mode --watch

Expected behavior

I expected the theme to change to the dark theme.

Context

  • Operating System and version: macOS High Sierra 10.13.6
  • Browser and version: Version 78.0.3904.108
  • JupyterLab version: 2.0.0a3
@tgeorgeux tgeorgeux added this to the 2.0 milestone Dec 10, 2019
@blink1073
Copy link
Member

I'm seeing this as well, perhaps related to #7147.

@tgeorgeux tgeorgeux mentioned this issue Dec 10, 2019
Merged
@jtpio
Copy link
Member

jtpio commented Dec 11, 2019

This should now be fixed on master (fixed by #7601).

@telamonian
Copy link
Member

fixed by #7601

@lock lock bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Jan 10, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug pkg:themes status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Milestone
2.0
Development

No branches or pull requests
4 participants
@jtpio @blink1073 @telamonian @tgeorgeux