Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kernel shut down doesn't switch to "No Kernel" #7690

Closed
jtpio opened this issue Dec 24, 2019 · 0 comments · Fixed by #7694
Closed

Kernel shut down doesn't switch to "No Kernel" #7690

jtpio opened this issue Dec 24, 2019 · 0 comments · Fixed by #7694
Labels
status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Milestone
2.0

Comments

@jtpio
Copy link
Member

jtpio commented Dec 24, 2019

From the latest master (023828a), shutting down a kernel session from the running tab doesn't change the session of the notebook to "No Kernel"

no-kernel

Similar thing when selecting the "No Kernel" option from the dialog:

no-kernel-dialog
@jasongrout jasongrout added this to the 2.0 milestone Dec 24, 2019
jasongrout added a commit to jasongrout/jupyterlab that referenced this issue Dec 24, 2019
@jasongrout
Be more careful about sessioncontext kernelChanged and sessionChanged…
3048d17 
… signal emisssions

Fixes jupyterlab#7690
@jasongrout jasongrout mentioned this issue Dec 24, 2019
Merged
@lock lock bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Jan 29, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Milestone
2.0
2 participants
@jasongrout @jtpio