Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debugger variables view mode UI #9425

Closed
karlaspuldaro opened this issue Dec 3, 2020 · 4 comments
Closed

Debugger variables view mode UI #9425

karlaspuldaro opened this issue Dec 3, 2020 · 4 comments
Labels
enhancement pkg:debugger status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Milestone

Comments

@karlaspuldaro
Copy link
Contributor

Problem

The current debugger UI allows variables display to toggle between table and tree views.
Maybe a toggle-switch may not be the best UI approach, as it implies on/off behaviour. Even though there are only 2 view modes to choose, the switch button purpose is only clarified on a mouse hover label Table/Tree view.

debugger

Proposed Solution

My suggestion would be using a button with an icon, giving the user a more clear visual understanding of its purpose.
An example would be the file browser view mode buttons on mac

Screen Shot 2020-12-03 at 1 35 49 PM

Either something like this where current view mode is highlighted, or,
keeping one button on display which on click switches the label & icon

image

Would like to hear more thoughts about this :)

@jtpio
Copy link
Member

jtpio commented Dec 4, 2020

Thanks @karlaspuldaro!

Maybe a toggle-switch may not be the best UI approach, as it implies on/off behaviour.

Agree. I think the reason there is a switch to toggle between the table and the tree views is because it was reused from the one in the toolbar.

Either something like this where current view mode is highlighted, or,
keeping one button on display which on click switches the label & icon

Having these icons instead sounds like a better alternative 👍 Would you like to open a PR so it can be tested out?

@karlaspuldaro
Copy link
Contributor Author

Thanks @jtpio for the feedback. Yes, I can definitely start implementing this idea for testing :)

@jtpio
Copy link
Member

jtpio commented Dec 4, 2020

Nice, thanks!

@jtpio
Copy link
Member

jtpio commented Jan 6, 2021

Fixed by #9502, thanks @karlaspuldaro!

@jtpio jtpio closed this as completed Jan 6, 2021
@jtpio jtpio added this to the 3.1 milestone Jan 6, 2021
@github-actions github-actions bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Jul 6, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement pkg:debugger status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Development

No branches or pull requests

2 participants