Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.0.x] Clean up browser check #10080

Merged
merged 1 commit into from Apr 12, 2021
Merged

[3.0.x] Clean up browser check #10080

merged 1 commit into from Apr 12, 2021

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Apr 12, 2021

References

Addresses error seen during 3.0.13 release - workspace file resulted in a 404 that caused browser_check to fail.

Code changes

Resets the JupyterLab layout state when running browser check.

User-facing changes

More robust browser_check for extension authors.

Backwards-incompatible changes

None

@jupyterlab-dev-mode
Copy link

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@blink1073 blink1073 added this to the 3.0.x milestone Apr 12, 2021
Copy link
Member

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073 blink1073 merged commit 07da432 into jupyterlab:3.0.x Apr 12, 2021
@jtpio jtpio deleted the reset-url branch April 12, 2021 10:51
@github-actions github-actions bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Oct 10, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
maintenance status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. tag:Testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants