-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add alt text to documentation #12879
Conversation
Co-authored-by: M. Eric Irrgang <mei2n@virginia.edu>
Co-authored-by: M. Eric Irrgang <mei2n@virginia.edu>
Co-authored-by: Matt Craig <mattwcraig@gmail.com>
Co-authored-by: Matt Craig <mattwcraig@gmail.com>
Co-authored-by: Aerik Pawson <45904740+aerikpawson@users.noreply.github.com>
Thanks for making a pull request to jupyterlab! |
Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com>
I turn away from this PR for a week and come back with two people to thank! I so appreciate all the help with this. @fcollonval many thanks for cleaning up the PR! @krassowski thank you for your thorough review and testing out the comments! I think I caught everything, but do let me know if there's more to fix. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Edit: the test failure is relevant:
/home/runner/work/jupyterlab/jupyterlab/docs/source/index.rst:20: WARNING: exception while evaluating only directive expression: chunk after expression
/home/runner/work/jupyterlab/jupyterlab/docs/source/user/running.rst:18: WARNING: exception while evaluating only directive expression: chunk after expression
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New line is needed between .. only:: comment
directive and the block.
@meeseeksdev please backport to 3.4.x |
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free to suggest an improvement. |
Thanks @isabela-pf! |
(cherry picked from commit 31b7832)
(cherry picked from commit 31b7832)
References
No issues solely address missing alt text in documentation, but #9399 mentions in in "Issue Area 6" as does its break out issue #9682. This PR does not fix either of those issues in their entirety.
Code changes
Changes in this PR
..alt..
for .rst and the space in![]
for .md)No other changes to the documentation are being made. It's worth noting this is does not cover all the images in JupyterLab's documentation.
User-facing changes
There are no visual changes in this PR. Alt text is not visible unless a link is broken or otherwise fails to load. For users of assistive tech like screen readers, their experience should now have the image described to them instead of reading the image file name as before.
Backwards-incompatible changes
As far as I know, nothing about this is backwards incompatible.
Thanks in advance for the review! If you have any questions about reviewing alt text, let me know and I'd be happy to tell you what I prioritize.
This alt text was contributed by wonderful volunteers at the SciPy 2022 sprints! They teamed up to make progress on so many images. I am just the messenger.
If you are curious how this was done, feel free to check out our working PR.