-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create JupyterLab 3.4.4 accessibility statement #14856
Conversation
Thanks for making a pull request to jupyterlab! |
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @isabela-pf
Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com>
@meeseeksdev please backport to 4.0.x |
@meeseeksdev please backport to 3.6.x |
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free to suggest an improvement. |
…14906) Co-authored-by: Isabela Presedo-Floyd <50221806+isabela-pf@users.noreply.github.com>
Thank you @fcollonval and @krassowski! 🌻 |
…14958) Co-authored-by: Isabela Presedo-Floyd <50221806+isabela-pf@users.noreply.github.com>
This PR adds an accessibility statement for JupyterLab 3.4.4 to the JupyterLab documentation. This is the same statement as has been on jupyter/accessibility documentation for some time now, barring formatting changes made to make this fit within the existing JupyterLab docs.
Please note that the version number the review applies to is not the most current release. Since many users do not update versions immediately, I've been asked to contribute this as it will still be relevant to our community (users and contributors and decision makers).
As always, review is welcome. I'll answer questions to the best of my ability, so thanks in advance for giving this a bit of your time. 🌻
References
There is no issue on JupyterLab singularly for adding an accessibility statement.
#14396's request for user-facing accessibility documentation is the closest. #9399's review is also referenced, and many of the issues persisted even though this statement was made for a more recent version.
Code changes
This adds a new page to the Getting Started documentation and adds an
accessibility
section to the Getting Started table of contents.User-facing changes
Users in the JupyterLab documentation will find a new section of Getting Started and a new page with a JupyterLab accessibility statement.
Backwards-incompatible changes
There are no backwards incompatible changes I am aware of.