-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve upgrade extension script #14882
Improve upgrade extension script #14882
Conversation
Thanks for making a pull request to jupyterlab! |
@krassowski if you have seen other things that could be improved let me know. |
The only thing that got me was |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As for the changes that are already in, LGTM. Not sure what you think about the lint config situation (an alternative to improving the upgrade script would be to revert the template to have them in individual files).
The script does not import the styling config from the template (only the |
Fix copying package.json for ui-tests
@meeseeksdev please backport to 4.0.x |
Co-authored-by: Frédéric Collonval <fcollonval@users.noreply.github.com>
References
Fixes jupyterlab/extension-template#36
Code changes
prepare
script when upgrading an extensionUser-facing changes
None
Backwards-incompatible changes
None