Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use config compatible with notebook 7 #14978

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

fcollonval
Copy link
Member

References

Follow-up of jupyterlab-contrib/jupyter-archive#118
Apply https://github.com/jupyter/notebook/blob/b5133c67f1a5c9c87d99abc44b7b04e6214aca45/ui-tests/test/jupyter_server_config.py#L18

Code changes

Use LabServerApp.extra_labextensions_path instead of LabApp.extra_labextensions_path in galata configuration to reduce customization needed for notebook 7

User-facing changes

None

Backwards-incompatible changes

None

@jupyterlab-probot
Copy link

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

@fcollonval
Copy link
Member Author

cc @jtpio

@fcollonval fcollonval added this to the 4.0.x milestone Aug 16, 2023
Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fcollonval fcollonval merged commit 6638a23 into jupyterlab:main Aug 16, 2023
76 of 82 checks passed
@fcollonval fcollonval deleted the enh/improve-galata-config branch August 16, 2023 08:55
@fcollonval
Copy link
Member Author

@meeseeksdev please backport to 4.0.x

meeseeksmachine pushed a commit to meeseeksmachine/jupyterlab that referenced this pull request Aug 16, 2023
fcollonval added a commit that referenced this pull request Aug 23, 2023
Co-authored-by: Frédéric Collonval <fcollonval@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants