Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the standard SQL mimetype #15180

Merged
merged 1 commit into from
Oct 1, 2023
Merged

Conversation

brichet
Copy link
Contributor

@brichet brichet commented Sep 29, 2023

This PR add the standard mimetype for SQL (application/sql) in codemirror languages, according to https://www.rfc-editor.org/rfc/rfc6922.html

User-facing changes

None

Backwards-incompatible changes

None

@jupyterlab-probot
Copy link

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @brichet

@krassowski krassowski merged commit 5574c7b into jupyterlab:main Oct 1, 2023
77 of 81 checks passed
@krassowski
Copy link
Member

@meeseeksdev please backport to 4.0.x

meeseeksmachine pushed a commit to meeseeksmachine/jupyterlab that referenced this pull request Oct 1, 2023
krassowski pushed a commit that referenced this pull request Oct 1, 2023
Co-authored-by: Nicolas Brichet <32258950+brichet@users.noreply.github.com>
@fcollonval fcollonval deleted the sql_mimetype branch October 2, 2023 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants